[FLINK-34180] Migrate doc website from ververica to flink #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOODBOY008
force-pushed
the
master-cdc-new
branch
2 times, most recently
from
beb598a
to
e669110
Compare
GOODBOY008
force-pushed
the
master-cdc-new
branch
from
ae114ae
to
c695eb8
Compare
PatrickRen
reviewed
Mar 6, 2024
There was a problem hiding this comment.
@GOODBOY008 Thanks for the awesome work! I left one comment.
.dlc.json
Outdated
| @@ -0,0 +1,32 @@ | |||
| { | |||
There was a problem hiding this comment.
What's the purpose of this file?
There was a problem hiding this comment.
This file I would like to check dead link in doc,but curretly do not active
There was a problem hiding this comment.
What about we introduce this file after we enable the dead link check in the future? I'm not sure links in this file currently are related to Flink CDC's doc.
GOODBOY008
force-pushed
the
master-cdc-new
branch
from
d1f2ce7
to
0fc2df7
Compare
GOODBOY008
force-pushed
the
master-cdc-new
branch
from
6331461
to
5b2f502
Compare
GOODBOY008
force-pushed
the
master-cdc-new
branch
from
5b2f502
to
7a357f9
Compare
GOODBOY008
force-pushed
the
master-cdc-new
branch
from
cd4e015
to
f76185d
Compare
PatrickRen
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
@GOODBOY008 Thanks for the PR! LGTM overall. Let's merge first and see if the doc can be built successfully.
wuzhenhua01
pushed a commit
to wuzhenhua01/flink-cdc-connectors
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FLINK-34180] Migrate doc website from ververica to flink.