Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34184] Update copyright and license file #3092

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

ruanhang1993
Copy link
Contributor

This PR updates copyright for each file and license file.

@Jiabao-Sun
Copy link
Contributor

Thanks @ruanhang1993 for this update.

Shall we change the NOTICE and site/NOTICE file as well?

flink-cdc/NOTICE

Lines 1 to 3 in f7fa317

flink-cdc-connectors
Copyright 2023 Ververica Inc.
Apache Flink, Flink®, Apache®, the squirrel logo, and the Apache feather logo are either registered trademarks or trademarks of The Apache Software Foundation.

Some files in the docs directory, such as Dockerfile, make.bat, site/index.html, appear to be missing a license header.

@ruanhang1993
Copy link
Contributor Author

ruanhang1993 commented Mar 5, 2024

Thanks @ruanhang1993 for this update.

Shall we change the NOTICE and site/NOTICE file as well?

flink-cdc/NOTICE

Lines 1 to 3 in f7fa317

flink-cdc-connectors
Copyright 2023 Ververica Inc.
Apache Flink, Flink®, Apache®, the squirrel logo, and the Apache feather logo are either registered trademarks or trademarks of The Apache Software Foundation.

Some files in the docs directory, such as Dockerfile, make.bat, site/index.html, appear to be missing a license header.

We have a different issue(https://issues.apache.org/jira/browse/FLINK-34183) to change the LICENSE files. I will raise another PR to change it. @Jiabao-Sun

@ruanhang1993
Copy link
Contributor Author

@Jiabao-Sun @leonardBang , the header of some files are not changed.

  1. termynal.css and termynal.js have the following header.
/**
 * termynal.js
 *
 * @author Ines Montani <[email protected]>
 * @version 0.0.1
 * @license MIT
 */
  1. The classes we copied from the debezium have the following header:
/*
 * Copyright Debezium Authors.
 *
 * Licensed under the Apache Software License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
 */

I am not sure how to change their headers. WDYT?

@leonardBang
Copy link
Contributor

@Jiabao-Sun @leonardBang , the header of some files are not changed.

  1. termynal.css and termynal.js have the following header.
/**
 * termynal.js
 *
 * @author Ines Montani <[email protected]>
 * @version 0.0.1
 * @license MIT
 */
  1. The classes we copied from the debezium have the following header:
/*
 * Copyright Debezium Authors.
 *
 * Licensed under the Apache Software License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
 */

I am not sure how to change their headers. WDYT?

I think we should keep current header.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 for the huge PR, LGTM

@leonardBang leonardBang merged commit a6c1b06 into apache:master Mar 6, 2024
13 checks passed
joyCurry30 pushed a commit to joyCurry30/flink-cdc-connectors that referenced this pull request Mar 22, 2024
wuzhenhua01 pushed a commit to wuzhenhua01/flink-cdc-connectors that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment