[FLINK-35540][cdc-common][cdc-connector][mysql] fix lost table when database and table are with the same name #3396
Conversation
| this( | ||
| container, | ||
| databaseName, | ||
| Integer.toUnsignedString(new Random().nextInt(), 36), | ||
| withIdentifier ? getIdentifier() : StringUtils.EMPTY, |
There was a problem hiding this comment.
The identifier suffix is meant to avoid test case conflicts since multiple cases might run simultaneously on a single MySQL database instance. It should be fine now since there's only one test case using this class, but might cause trouble in the future if more testcases are added.
There was a problem hiding this comment.
Generally I would prefer not to change UniqueDatabase, and some alternative approaches are 1) Keep using UniqueDatabase to test identical DB and table name scenario, create tables during tests or 2) Create another class like CustomDatabase which allows specifying database name directly without appending suffix. Looking forward to hearing @qg-lin's thoughts.
There was a problem hiding this comment.
Good idea! I'll rewrite the case.
There was a problem hiding this comment.
Thanks for @qg-lin's nice work! Also please run mvn spotless:apply to fix format violations before it could be merged.
cc @leonardBang
… and table are with the same name
leonardBang
force-pushed
the
fix-lost-db-and-table-same-name
branch
from
38cad83
to
8f1935e
Compare
…e with the same name This closes apache#3396.
https://issues.apache.org/jira/browse/FLINK-35540