[minor][cdc-connector][oracle] OracleSchema getTableSchema Description Modified #3443
Conversation
ChengJie1053
changed the title
| * Gets table schema for the given table path. It will request to MySQL server by running `SHOW | ||
| * CREATE TABLE` if cache missed. | ||
| */ | ||
| /** Gets table schema for the given table path. It will request to Oracle server by running */ |
There was a problem hiding this comment.
Is this sentence complete?
There was a problem hiding this comment.
It is complete, because I found that it was not obtained by executing sql, it was obtained by java.sql.connect #getMetaData
There was a problem hiding this comment.
Gets the table schema for a given table path. It will request from the Oracle server via java.sql.connect #getMetaData
There was a problem hiding this comment.
Or is it ok if I change it to this
There was a problem hiding this comment.
Since there's no server request at all, what about removing It will request to Oracle server by running?
Or is it ok if I change it to this
Sorry I missed your reply, I think you're right on this.
There was a problem hiding this comment.
/** Gets table schema for the given table path. */
Is it OK to change it like this
ChengJie1053
changed the title
…a doc description This closes apache#3443.
…a doc description This closes apache#3443.
OracleSchema getTableSchema Description Changed from
mysqltooracle