Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Optimize SchemaChangeEventVisitor: use generic visitor handler class & introduce voidVisitors #3638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[hotfix] Optimize SchemaChangeEventVisitor: use generic visitor handler class & introduce voidVisitors #3638

wants to merge 1 commit into from

Conversation

yuxiqian
Copy link
Contributor

This PR cleans up SchemaChangeEventVisitor class by:

  • Using templated VisitorHandler<EVT, T, E> to replace individual XXXEventVisitor classes
  • Introduce voidVisit method for visitors that don't yield a returning value

@yuxiqian
[hotfix] Optimize SchemaChangeEventVisitor: use generic visitor handl…
b6a005b 
…er class & introduce voidVisitors

Signed-off-by: yuxiqian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common doris-pipeline-connector paimon-pipeline-connector runtime starrocks-pipeline-connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuxiqian