[FLINK-31986][Connectors/Kinesis] Setup integration tests for FLIP-27 Kinesis source #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elphastori
changed the title
hlteoh37
reviewed
Oct 3, 2024
Comment on lines
+125
to
+130
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>s3</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
There was a problem hiding this comment.
Why do we test using s3? Can we use kinesis instead?
There was a problem hiding this comment.
We are actually testing Kinesis only. The S3 dependency is required because the LocalStack container in the connector base arbitrarily creates an S3 bucket and lists its contents to test readiness. LocalstackContainer.java#L61-L83
hlteoh37
reviewed
Oct 3, 2024
...eams/src/test/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSourceITCase.java
Outdated
Show resolved
Hide resolved
hlteoh37
reviewed
Oct 3, 2024
...eams/src/test/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSourceITCase.java
Show resolved
Hide resolved
hlteoh37
requested changes
Oct 3, 2024
hlteoh37
approved these changes
Oct 4, 2024
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Sets up Integrations tests for the FLIP-27 DataStreams API Kinesis source
Verifying this change
This change added tests and can be verified as follows: