-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-30757] Upgrade busybox version to a pinned version for operator #530
Conversation
3612645
to
dfd1943
Compare
Busybox latest (1.36.0) is unstable -> docker-library/busybox#162 |
80233f2
to
f8c9d35
Compare
Hi @gyfora @gaborgsomogyi , the pipeline checks with 1.35.0 busybox version passed. Should we wait for docker-library/busybox#162 to be solved or we are good with 1.35.0 version? |
I'm fine with 1.35.0 as long as it's stable. The main feature what I was personally missing is the failure log for init containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, decent job. I've tried it out and looks good, only added some comments to make the output easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi @gyfora, the latest Java integration test failed. Could you please help me retrigger the ci pipeline again? I tested the integration test locally and it passed. |
What is the purpose of the change
Since e2e test is flaky with latest busybox image in init container, we pinned the image version to a relatively old version. This pull request would like to enable e2e test print init container log and try to upgrade busybox version to the latest pinned version.
Brief change log
Verifying this change
This change is already covered by existing tests, such as
e2e-tests/test_application_kubernetes_ha.sh
.To reproduce the failed tests locally and test modified init container log printing code:
e2e-tests/data/flinkdep-cr.yaml
tocommand: ['/bin/sh', '-c', 'wget https://repo1.maven.org/maven2/org/apache/flink/flink-examples-streaming_2.12/1.14.4/flink-examples-streaming_2.12-1.14.4.jar -O /flink-artifact/myjob.jar; echo "test error msg"; exit 1;']
../e2e-tests/test_application_kubernetes_ha.sh
.Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors
: noDocumentation