-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support accumulo's new default ssh behavior #307
Support accumulo's new default ssh behavior #307
Conversation
292a774
to
aac7e62
Compare
When using the accumulo-cluster script in 2.1.4-snapshot, all connections now default to being done via ssh vs a local command. This change modifies the accumulo commands used to ensure that local start/stop commands are used so that uno's environment variables are used by accumulo-env.sh
aac7e62
to
261e354
Compare
Co-authored-by: Christopher Tubbs <[email protected]>
Co-authored-by: Christopher Tubbs <[email protected]>
Co-authored-by: Christopher Tubbs <[email protected]>
Do you know if you have to handle |
That was originally why I had the wildcard at the end of the regex for However our current SNAPSHOT is 2.1.4-SNAPSHOT which is handled by the else case, so I think we are good. |
That would have only matched on repetitions of
Good point. It's unlikely somebody's going to use uno to test a snapshot of an earlier version. Of course, for the 2.1.4-SNAPSHOT case, it depends on my PR in the main repo getting merged to backport |
When using the accumulo-cluster script in 2.1.4-snapshot, all connections now default to being done via ssh vs a local command.
This change modifies the accumulo commands used to ensure that local start/stop commands are used so that uno's environment variables are used by accumulo-env.sh