Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support accumulo's new default ssh behavior #307

Merged

Conversation

ddanielr
Copy link
Contributor

When using the accumulo-cluster script in 2.1.4-snapshot, all connections now default to being done via ssh vs a local command.

This change modifies the accumulo commands used to ensure that local start/stop commands are used so that uno's environment variables are used by accumulo-env.sh

@ddanielr ddanielr force-pushed the bugfix/support-accumulo-cluster-changes branch 2 times, most recently from 292a774 to aac7e62 Compare December 13, 2024 19:38
When using the accumulo-cluster script in 2.1.4-snapshot, all
connections now default to being done via ssh vs a local command.

This change modifies the accumulo commands used to ensure that local
start/stop commands are used so that uno's environment variables are
used by accumulo-env.sh
@ddanielr ddanielr force-pushed the bugfix/support-accumulo-cluster-changes branch from aac7e62 to 261e354 Compare December 13, 2024 19:43
ddanielr and others added 3 commits December 13, 2024 14:45
Co-authored-by: Christopher Tubbs <[email protected]>
Co-authored-by: Christopher Tubbs <[email protected]>
Co-authored-by: Christopher Tubbs <[email protected]>
@ctubbsii
Copy link
Member

Do you know if you have to handle -SNAPSHOT here? It seems like you might.

@ddanielr
Copy link
Contributor Author

Do you know if you have to handle -SNAPSHOT here? It seems like you might.

That was originally why I had the wildcard at the end of the regex for [0-3].

However our current SNAPSHOT is 2.1.4-SNAPSHOT which is handled by the else case, so I think we are good.

@ctubbsii
Copy link
Member

Do you know if you have to handle -SNAPSHOT here? It seems like you might.

That was originally why I had the wildcard at the end of the regex for [0-3].

That would have only matched on repetitions of [0-3]. If you had an earlier version that had a [0-3].*, then I missed it. I doubt we'll reach double digit patch releases, so my correction probably wasn't really important, I suppose.

However our current SNAPSHOT is 2.1.4-SNAPSHOT which is handled by the else case, so I think we are good.

Good point. It's unlikely somebody's going to use uno to test a snapshot of an earlier version. Of course, for the 2.1.4-SNAPSHOT case, it depends on my PR in the main repo getting merged to backport --local

@ctubbsii ctubbsii merged commit e8f3ba9 into apache:main Dec 13, 2024
2 checks passed
@ddanielr ddanielr deleted the bugfix/support-accumulo-cluster-changes branch December 18, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants