feat(python): guide cython to optimize code generation #1905
+60
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimize the C++ code generated by Cython by modifying the function implementations of the Buffer class.
Using
get_int8
as an example, the following C++ code is generated before modification.Since get_int32 returns a C++ type, the cython needs to generate calling
PyLong_FromLong
, and guard code such as callingPyErr_Occurred
.However, it is known that int32 can always be used to generate a
PyLongObject
withPyLong_FromLong
. Therefore, when we manually call this, the cython only needs to check if the return value is null, as shown in the following code.Related issues
Does this PR introduce any user-facing change?
Benchmark
Microbenchmark case:
Result: