Skip to content

[#4993] feat(iceberg): integrate credential framework to iceberg REST server #936

[#4993] feat(iceberg): integrate credential framework to iceberg REST server

[#4993] feat(iceberg): integrate credential framework to iceberg REST server #936

Triggered via pull request October 17, 2024 07:41
Status Failure
Total duration 2m 43s
Artifacts

trino-integration-test.yml

on: pull_request
changes
4s
changes
Matrix: TrinoIT
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 2 warnings
TrinoIT (linux/amd64, 17): task ':iceberg:iceberg-rest-server:spotlessJavaCheck'#L1
Execution failed for task ':iceberg:iceberg-rest-server:spotlessJavaCheck': The following files had format violations: src/main/java/org/apache/gravitino/iceberg/provider/ConfigBasedIcebergCatalogConfigProvider.java @@ -68,7 +68,7 @@ ··} ··@OverRide -··public··Optional<IcebergConfig>·getIcebergCatalogConfig(String·catalogName)·{ +··public·Optional<IcebergConfig>·getIcebergCatalogConfig(String·catalogName)·{ ····return·Optional.ofNullable(catalogConfigs.get(catalogName)); ··} src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java @@ -194,9 +194,8 @@ ····//·todo·support·snapshots ····TableIdentifier·tableIdentifier·= ········TableIdentifier.of(RESTUtil.decodeNamespace(namespace),·table); -····LoadTableResponse·loadTableResponse·=·icebergCatalogWrapperManager -········.getOps(prefix) -········.loadTable(tableIdentifier); +····LoadTableResponse·loadTableResponse·= +········icebergCatalogWrapperManager.getOps(prefix).loadTable(tableIdentifier); ····if·(isCredentialVending)·{ ······return·IcebergRestUtils.ok(injectCredentialConfig(prefix,·loadTableResponse)); ····}·else·{ src/test/java/org/apache/gravitino/iceberg/provider/TestConfigBasedIcebergCatalogWrapperProvider.java @@ -67,12 +67,12 @@ ····IcebergConfig·hiveIcebergConfig·=·provider.catalogConfigs.get(hiveCatalogName); ····IcebergConfig·jdbcIcebergConfig·=·provider.catalogConfigs.get(jdbcCatalogName); ····IcebergConfig·defaultIcebergConfig·=·provider.catalogConfigs.get(defaultCatalogName); -····IcebergCatalogWrapper·hiveOps·=·new·IcebergCatalogWrapper( -········provider.getIcebergCatalogConfig(hiveCatalogName).get()); -····IcebergCatalogWrapper·jdbcOps·=·new·IcebergCatalogWrapper( -········provider.getIcebergCatalogConfig(jdbcCatalogName).get()); -····IcebergCatalogWrapper·defaultOps·=·new·IcebergCatalogWrapper( -········provider.getIcebergCatalogConfig(defaultCatalogName).get()); +····IcebergCatalogWrapper·hiveOps·= +········new·IcebergCatalogWrapper(provider.getIcebergCatalogConfig(hiveCatalogName).get()); +····IcebergCatalogWrapper·jdbcOps·= +········new·IcebergCatalogWrapper(provider.getIcebergCatalogConfig(jdbcCatalogName).get()); +····IcebergCatalogWrapper·defaultOps·= +········new·IcebergCatalogWrapper(provider.getIcebergCatalogConfig(defaultCatalogName).get()); ····Assertions.assertEquals( ········hiveCatalogName,·hiveIcebergConfig.get(IcebergConfig.CATALOG_BACKEND_NAME)); src/test/java/org/apache/gravitino/iceberg/provider/TestGravitinoBasedIcebergCatalogWrapperProvider.java @@ -77,8 +77,10 @@ ····Mockito.when(client.loadMetalake(Mockito.any())).thenReturn(gravitinoMetalake); ····provider.setClient(client); -····IcebergCatalogWrapper·hiveOps·=·new·IcebergCatalogWrapper(provider.getIcebergCatalogConfig(hiveCatalogName).get()); -····IcebergCatalogWrapper·jdbcOps·=·new·IcebergCatalogWrapper(provider.getIcebergCatalogConfig(jdbcCatalogName).get()); ... (7 more lines that didn't fit) Run './gradlew :iceberg:iceberg-rest-server:spotlessApply' to fix these violations. at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111) at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53) at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:58) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAc
TrinoIT (linux/amd64, 17)
Process completed with exit code 1.
changes
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
TrinoIT (linux/amd64, 17)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, docker/setup-qemu-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/