[#4962] feat(trino-connector): Support the Trino cascading connector #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diqiu50
changed the title
yuqi1129
reviewed
Sep 24, 2024
| Normally, the directory location is `Trino-server-<version>/plugin`, and the directory contains other catalogs used by Trino. | ||
|
|
||
| Ensure that the `plugin` directory contains `gravitino` and | ||
| `trino` subdirectories. Two Trino clusters need to be deployed on machines with hostnames `c1-trino` and `c2-trino`. |
There was a problem hiding this comment.
Two Trino clusters need to be deployed on machines with hostnames
c1-trinoandc2-trino.
I believe what you want to express is that Assuming the hostnames of the machines in which the two Trino cluster deployed are c1-trinoandc2-trino``.
The hostname should not necessarily be c1-trino and c2-trino, so other name is okay, is that right?
Comment on lines
45
to
55
| ```bash | ||
| docker run --name c1-trino -d -p 8080:8080 <image-name> -v `gravitino-trino-connector-<version>`:/usr/lib/trino/plugin/gravitino | ||
| -v `gravitino-trino-cascading-connector-<version>`:/usr/lib/trino/plugin/trino | ||
| ``` | ||
|
|
||
| To start Trino on the host `c2-trino` and mount the plugins. execute the following command: | ||
|
|
||
| ```bash | ||
| docker run --name c1-trino -d -p 8080:8080 <image-name> -v `gravitino-trino-connector-<version>`:/usr/lib/trino/plugin/gravitino | ||
| -v `gravitino-trino-cascading-connector-<version>`:/usr/lib/trino/plugin/trino | ||
| ``` |
There was a problem hiding this comment.
You can merge them as
docker run --name {machine_hostname} -d -p 8080:8080 <image-name> -v `gravitino-trino-connector-<version>`:/usr/lib/trino/plugin/gravitino
-v `gravitino-trino-cascading-connector-<version>`:/usr/lib/trino/plugin/trino
yuqi1129
reviewed
Sep 25, 2024
|
|
||
| ## Deploying Trino | ||
|
|
||
| To set up the Trino cascading query environment, you should first deploy at least two Trino environments. |
There was a problem hiding this comment.
@mchades Please also take a look.
mchades
reviewed
Sep 25, 2024
mchades
reviewed
Sep 25, 2024
...c/main/java/org/apache/gravitino/trino/connector/catalog/DefaultCatalogConnectorFactory.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support the Trino cascading connector
Why are the changes needed?
Fix: #4962
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add some ut and Manually test