Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oceanbase-catalog): Support schema operations for OceanBase JDBC catalog. #5013

Merged
merged 4 commits into from
Oct 9, 2024
Merged

feat(oceanbase-catalog): Support schema operations for OceanBase JDBC catalog. #5013

merged 4 commits into from
Oct 9, 2024

Conversation

yuanoOo
Copy link
Contributor

@yuanoOo yuanoOo commented Sep 25, 2024

What changes were proposed in this pull request?

  • Support schema operations for OceanBase JDBC catalog.
  • Add OceanBaseContainer to test schema operations.

Why are the changes needed?

Fix: #4990

Does this PR introduce any user-facing change?

no

How was this patch tested?

Add unit test: TestOceanBaseDatabaseOperations.

@yuanoOo
Copy link
Contributor Author

yuanoOo commented Sep 25, 2024

@mchades PTAL.

@jerryshao jerryshao requested a review from mchades October 9, 2024 03:06
@jerryshao
Copy link
Contributor

@mchades can you please move forward this PR?

mchades
mchades approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contributions and sorry for my later response.

I think the next PR should be support simple table operations for Oceanbase catalog

@mchades mchades merged commit 437c41b into apache:main Oct 9, 2024
26 checks passed
@yuanoOo
Copy link
Contributor Author

yuanoOo commented Oct 12, 2024

LGTM. Thanks for your contributions and sorry for my later response.

I think the next PR should be support simple table operations for Oceanbase catalog

I think it might be a better choice to implement the org.apache.gravitino.catalog.oceanbase.converter package first. Both schema and table operations depend on it, and we can test it while testing schema and table operations.What do you think?

@mchades
Copy link
Contributor

mchades commented Oct 12, 2024

LGTM. Thanks for your contributions and sorry for my later response.
I think the next PR should be support simple table operations for Oceanbase catalog

I think it might be a better choice to implement the org.apache.gravitino.catalog.oceanbase.converter package first. Both schema and table operations depend on it, and we can test it while testing schema and table operations.What do you think?

ok, plz go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchades mchades mchades approved these changes

Assignees

@yuanoOo yuanoOo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] Support schema operations for OceanBase JDBC catalog
3 participants
@yuanoOo @jerryshao @mchades