[#5071] Improvement (test): Add integration tests for Trino cascading queries #5073
Conversation
diqiu50
changed the title
| @@ -76,7 +76,7 @@ jobs: | |||
|
|
|||
| - name: Package Gravitino | |||
| run: | | |||
| ./gradlew compileDistribution -x test -PjdkVersion=${{ matrix.java-version }} | |||
| ./gradlew build compileDistribution -x test -PjdkVersion=${{ matrix.java-version }} | |||
There was a problem hiding this comment.
Why do we need to add the build task? I believe the build task is included in compileDistribution
There was a problem hiding this comment.
the compileDistribution task does not build the Trino connector
| #create test metalake | ||
| counter=0 | ||
| while [ $counter -le 30 ]; do | ||
| sleep 1 |
There was a problem hiding this comment.
Better move this line to L53.
There was a problem hiding this comment.
We need to pause for a moment because the Gravitino server has not completed startup.
| cp -r /opt/gravitino-server /tmp/gravitino-server | ||
| rm -fr /tmp/gravitino-server/logs | ||
| rm -fr /tmp/gravitino-server/data | ||
| /tmp/gravitino-server/bin/gravitino.sh start |
There was a problem hiding this comment.
When will you stop the Gravitino server? I haven't noticed such logic in the PR.
There was a problem hiding this comment.
The Gravitino server was stopped by the container shutdown.
| # under the License. | ||
|
|
||
| connector.name=trino | ||
| connection-url=jdbc:trino://trino-remote:8080/tpcds |
There was a problem hiding this comment.
${trino-remote-address}:${trino-remote-port}
There was a problem hiding this comment.
That URL is a valid connection-url used by the Docker Compose environment.
What changes were proposed in this pull request?
Add integration tests for Trino cascading queries
Why are the changes needed?
Fix: #5071
Does this PR introduce any user-facing change?
NO
How was this patch tested?
New integration testers