[#5105] improvement(server,client): Error code optimization about access control API #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Oct 18, 2024
| import com.google.errorprone.annotations.FormatString; | ||
|
|
||
| /** An exception thrown when a metadata object is invalid. */ | ||
| public class IllegalMetadataObjectException extends IllegalArgumentException { |
There was a problem hiding this comment.
How do you define "illegal"?
There was a problem hiding this comment.
If a metadata object in the path doesn't exist, we will return NotFoundException.
If a metadata object in the request body doesn't exist, we will return IllegalException.
jerryshao
reviewed
Oct 18, 2024
| new UserResponse( | ||
| DTOConverters.toDTO( | ||
| accessControlManager.grantRolesToUser( | ||
| metalake, request.getRoleNames(), user))))))); | ||
| metalake, request.getRoleNames(), user)))); | ||
| } catch (NoSuchRoleException nsr) { |
There was a problem hiding this comment.
I think it is better to handle IllegalRoleException in the core, not convert to this exception in here.
There was a problem hiding this comment.
OK , just in my view, I usually throw IllegalxxxException in the other Operation class. It's ok to throw in the core module.
…t access control API
jerryshao
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Error code optimization about access control API
Why are the changes needed?
Fix: #5105
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Modify some UTs