HBASE-29082: Support for custom meta table name suffix #6632
+163
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anmolnar
reviewed
Jan 29, 2025
| * Added in HBASE-XXXXX to support having multiple hbase:meta tables (with distinct names )to | ||
| * enable storage sharing by more than one clusters. | ||
| */ | ||
|
|
| String suffix_val = String.valueOf(conf.getStrings( | ||
| HConstants.HBASE_META_TABLE_SUFFIX, HConstants.HBASE_META_TABLE_SUFFIX_DEFAULT_VALUE)); | ||
|
|
||
| if (suffix_val == null||suffix_val.isEmpty()) { |
There was a problem hiding this comment.
Use proper formatting:
if (suffix_val == null || suffix_val.isEmpty()) {
Comment on lines
86
to
89
| LOG.debug("Default value for Hbase meta table is being chosen."); | ||
| return TableName.META_TABLE_NAME; | ||
| } | ||
| LOG.debug("Suffix value for Hbase meta table is being chosen."); |
There was a problem hiding this comment.
Instead of emitting 2 separate log messages, add a single one at INFO level.
LOG.info("Meta table name: {}", META_TABLE_NAME);
Comment on lines
75
to
82
| String suffix_val = String.valueOf(conf.getStrings( | ||
| HConstants.HBASE_META_TABLE_SUFFIX, HConstants.HBASE_META_TABLE_SUFFIX_DEFAULT_VALUE)); | ||
|
|
||
| if (suffix_val == null||suffix_val.isEmpty()) { | ||
| return TableName.META_TABLE_NAME; | ||
| } | ||
| return valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "meta_" | ||
| + suffix_val); |
There was a problem hiding this comment.
Don't duplicate the logic, put it at a common place: keep it here or in the other class, or put it in a common utility.
| @@ -78,6 +94,7 @@ private static TableDescriptor writeFsLayout(Path rootDir, Configuration conf) | |||
| Path tableDir = CommonFSUtils.getTableDir(rootDir, TableName.META_TABLE_NAME); | |||
| if (fs.exists(tableDir) && !fs.delete(tableDir, true)) { | |||
| LOG.warn("Can not delete partial created meta table, continue..."); | |||
| throw new HBaseIOException("Specified meta table already exists."); | |||
There was a problem hiding this comment.
We might not need this I believe for 2 reasons:
- we should keep the original logic here for backward compatiblity,
- you throw this exception only in the case when HBase tried to delete
tableDir, but it wasn't successful
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anmolnar
reviewed
Feb 11, 2025
| } | ||
|
|
||
| public static TableName initializeHbaseMetaTableName(Configuration conf) { | ||
| String suffix_val = String.valueOf(conf.getStrings( |
There was a problem hiding this comment.
Meta table suffix is just a string. I think this should be conf.get(...)
anmolnar
reviewed
Feb 11, 2025
Comment on lines
67
to
71
| protected final Configuration conf; | ||
| public InitMetaProcedure(Configuration conf) { | ||
| this.conf = conf; | ||
| } | ||
|
|
There was a problem hiding this comment.
You probably don't need this constructor at all if you return TableName.META_TABLE_NAME in getTableName() method. Actually don't need to modify this class at all.
|
my patch: #6683 |
anmolnar
reviewed
Feb 12, 2025
Comment on lines
94
to
99
| if (suffix_val == null || suffix_val.isEmpty()) { | ||
| LOG.info("Meta table name: {}", META_TABLE_NAME); | ||
| return TableName.META_TABLE_NAME; | ||
| } |
There was a problem hiding this comment.
This is incorrect: META_TABLE_NAME is being initialized in this method, so you end up returning null value.
kabhishek4
force-pushed
the
rorep
branch
2 times, most recently
from
f388c45 to
0462bc4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.