HBASE-29093 Load userSnapshots.jsp only on master status page #6696

PDavid · 2025-02-16T07:54:37Z

Before HBase UI always tried to load userSnapshots.jsp with an AJAX request on all UI pages - NOK.

This happened even on RegionServer UI or REST UI where this call always failed with HTTP 500.

From now on HBase UI only loads userSnapshots.jsp when the Snapshots tab (div with tab_userSnapshots ID) exists on the page.

Also did a minor improvement to tab.js: use const instead of var as var has so many problems:

With block-level scope, no hoisting, and the ability to declare constants, let and const make code more predictable, maintainable, and less error-prone. By using let and const instead of var, developers can avoid common pitfalls and write more declarative code.

Also fixed a whitespace.

(cherry picked from commit ed007404b0f31a51e2c5960c21340993073b7f06)

Before HBase UI always tried to load `userSnapshots.jsp` with an AJAX request on all UI pages - **NOK**. This happened even on RegionServer UI or REST UI where this call always failed with HTTP 500. From now on HBase UI only loads `userSnapshots.jsp` when the Snapshots tab (div with `tab_userSnapshots` ID) exists on the page. Also did a minor improvement to `tab.js`: use `const` instead of `var` as `var` has so many problems: > With block-level scope, no hoisting, and the ability to declare constants, let and const make code more predictable, maintainable, and less error-prone. By using let and const instead of var, developers can avoid common pitfalls and write more declarative code. Also fixed a whitespace. (cherry picked from commit ed007404b0f31a51e2c5960c21340993073b7f06)

PDavid · 2025-02-16T07:55:10Z

This is a backport of #6627 on branch-2.5.

PDavid · 2025-02-16T08:03:54Z

Tested this locally the same way as described here: #6627 (comment)

Apache-HBase · 2025-02-16T08:18:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 17s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 15s		branch-2.5 passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		12m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6696
Optional Tests	dupname asflicense javac codespell detsecrets jshint spotless
uname	Linux d9a05c952460 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `dd74834`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-02-16T12:05:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 2s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 13s		branch-2.5 passed
+1 💚	javadoc	0m 31s		branch-2.5 passed
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 9s		the patch passed
+1 💚	javadoc	0m 24s		the patch passed
			_ Other Tests _
+1 💚	unit	224m 45s		hbase-server in the patch passed.
		239m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6696
Optional Tests	javac javadoc unit
uname	Linux 84a6a1494699 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `dd74834`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/testReport/
Max. process+thread count	4274 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-02-16T12:31:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 57s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 29s		branch-2.5 passed
+1 💚	javadoc	0m 24s		branch-2.5 passed
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 22s		the patch passed
+1 💚	javadoc	0m 24s		the patch passed
			_ Other Tests _
+1 💚	unit	252m 1s		hbase-server in the patch passed.
		265m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6696
Optional Tests	javac javadoc unit
uname	Linux 274567645ecf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `dd74834`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/testReport/
Max. process+thread count	4150 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-02-16T12:36:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 15s		branch-2.5 passed
+1 💚	javadoc	0m 27s		branch-2.5 passed
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
			_ Other Tests _
+1 💚	unit	257m 11s		hbase-server in the patch passed.
		270m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6696
Optional Tests	javac javadoc unit
uname	Linux 05b2fd013602 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `dd74834`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/testReport/
Max. process+thread count	4460 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6696/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid mentioned this pull request Feb 16, 2025

HBASE-29093 Load userSnapshots.jsp only on master status page #6627

Open

PDavid marked this pull request as ready for review February 18, 2025 08:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-29093 Load userSnapshots.jsp only on master status page #6696

HBASE-29093 Load userSnapshots.jsp only on master status page #6696

PDavid commented Feb 16, 2025

PDavid commented Feb 16, 2025

PDavid commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025

HBASE-29093 Load userSnapshots.jsp only on master status page #6696

Are you sure you want to change the base?

HBASE-29093 Load userSnapshots.jsp only on master status page #6696

Conversation

PDavid commented Feb 16, 2025

PDavid commented Feb 16, 2025

PDavid commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025

Apache-HBase commented Feb 16, 2025