-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-29148: BufferedMutator should be able to flush after buffering a certain number of mutations #6718
Open
charlesconnell
wants to merge
2
commits into
apache:master
Choose a base branch
from
HubSpot:HBASE-29148/buffered-mutator-mutation-limit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HBASE-29148: BufferedMutator should be able to flush after buffering a certain number of mutations #6718
charlesconnell
wants to merge
2
commits into
apache:master
from
HubSpot:HBASE-29148/buffered-mutator-mutation-limit
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…a certain number of mutations
628796b
to
0de147b
Compare
This comment has been minimized.
This comment has been minimized.
Apache9
approved these changes
Feb 25, 2025
This comment has been minimized.
This comment has been minimized.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At my company I've been experimenting with enabling
hbase.rpc.rows.size.threshold.reject
on our RegionServers as a protective measure, to prevent Java OOMs caused by large Multi requests. This has caused issues for some clients usingBufferedMutator
s, which send large batches of mutations, sometimes all to a single RegionServer. It theBufferedMutator
had a way to flush before hitting the RegionServer'shbase.rpc.rows.warning.threshold
, then it could gets its mutations done successfully. This is easy to add.