[refactor] refactoring methods replaceCryPlaceholder and replaceSmilingPlace #2832
+125
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngPlace in CollectUtil.java for readability and to reuse common code
hasimmollah
changed the title
hasimmollah
changed the title
…ngPlace in CollectUtil.java for readability and to reuse common code with comment
|
hi, thanks for contribution! |
tomsun28
changed the title
|
Added few more test cases now to improve test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
#2056
Issue 2056 was raised to refactor CollectUtil.java for more readability. Refactoring methods replaceCryPlaceholder and replaceSmilingPlace in CollectUtil.java for readability and to reuse common code extracted codes to replace special character. As this part is common for the scenario when json element is JsonObject or JsonArray in replaceCryPlaceholder and also for replaceSmilingPlace
Checklist
Add or update API