[WIP: do not review] HIVE-28712: Fix error wrt maxParts in partition logs #5635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arorasimran0309
force-pushed
the
maxparts
branch
from
b1caa67 to
69e68b9
Compare
|
arorasimran0309
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The changes include passing the config value LIMIT_PARTITION_REQUEST instead of maxparts (whose value is set to -1) in get_partitions_by_expr logging expression. This will help in reflecting the correct quantity in case the config is set and being honored with the filter/expr on the partition column
Why are the changes needed?
Current partition logs display max partitions = -1, which is the default value. But on changing the value of LIMIT_PARTITION_REQUEST, the set value is not displayed, instead -1 continues to be logged.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Existing tests
Case 1: Test passing, before the fix:
After the fix:
Case 2: Test failing, before the fix:
After the fix:
