HIVE-28748: Docker: Redirect daemon's logs to STDOUT #5638
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okumin
commented
Feb 9, 2025
| <property> | ||
| <name>hive.compactor.worker.threads</name> | ||
| <value>1</value> | ||
| </property> |
There was a problem hiding this comment.
This configuration is required to run major compactions. I created this patch while while I was debugging OPTIMIZE TABLE ... REWRITE DATA of Iceberg tables.
2025-02-09T13:03:22,303 WARN [main] server.HiveServer2: Invalid number of Compactor Worker threads(0) on HS2
2025-02-09T13:03:22,315 WARN [main] server.HiveServer2: No default compaction pool configured, all non-labeled compaction requests will remain unprocessed!
okumin
force-pushed
the
HIVE-28748-stdout
branch
from
529b026 to
879f716
Compare
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Put the default log4j properties in the official Docker image.
Why are the changes needed?
File-based logging is inconvenient, and it doesn't follow the common practice of containers.
Does this PR introduce any user-facing change?
Yes.
Is the change a dependency upgrade?
No.
How was this patch tested?
I tested the output in my local machine.