Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle converting Utf8View & BinaryView to Iceberg schema #831

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Handle converting Utf8View & BinaryView to Iceberg schema #831

merged 2 commits into from
Jan 13, 2025

Conversation

phillipleblanc
Copy link
Contributor

Adds the Utf8View and BinaryView types to be properly converted into the Iceberg schema.

#787 partially implemented the Utf8View, but there was a step missed from the visit_type function.

sdd
sdd approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sdd sdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the contribution!

@sdd sdd merged commit 105e513 into apache:main Jan 13, 2025
16 checks passed
@phillipleblanc phillipleblanc deleted the phillip/241221-utf8-view branch January 13, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdd sdd sdd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillipleblanc @sdd