Core: Support removing keys from EnvironmentContext #12103
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshkv
force-pushed
the
wr/environment-context-remove
branch
from
ae4c7be to
05453bf
Compare
nastra
reviewed
Jan 28, 2025
| * | ||
| * @param key The key whose value to remove | ||
| */ | ||
| public static void remove(String key) { |
There was a problem hiding this comment.
maybe the return type should be String here and the method would return PROPERTIES.remove(key). That way the test wouldn't need to check assertThatNoException().isThrownBy(() -> EnvironmentContext.remove("test-key")); but rather would make sure that the method returned the value on the first remove and null on the second remove
nastra
reviewed
Jan 29, 2025
core/src/test/java/org/apache/iceberg/TestEnvironmentContext.java
Outdated
Show resolved
Hide resolved
nastra
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny change to support removing keys from
EnvironmentContext.Useful when a JVM is shared by multiple jobs and jobs want to express different environment properties.