IGNITE-23513 Use limited representation for arrays in BinaryObjectExImpl::toString #11610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizhikov
reviewed
Oct 25, 2024
| @@ -313,9 +320,16 @@ else if (val instanceof Object[]) { | |||
|
|
|||
| appendValue(o, buf, ctx, handles); | |||
|
|
|||
| if (i == COLLECTION_LIMIT - 1) | |||
There was a problem hiding this comment.
int len = Math.min(arr.length, COLLECTION_LIMIT);
for (int i = 0; i < len; i++) {
Object o = arr[i];
appendValue(o, buf, ctx, handles);
if (i < len - 1)
buf.a(", ");
}
nizhikov
reviewed
Oct 25, 2024
| @@ -66,6 +69,10 @@ public abstract class BinaryObjectExImpl implements BinaryObjectEx { | |||
| */ | |||
| public abstract long offheapAddress(); | |||
|
|
|||
| /** */ | |||
| private static final int COLLECTION_LIMIT = | |||
There was a problem hiding this comment.
Let's reuse constant from GridToStringBuilder.
nizhikov
approved these changes
Oct 28, 2024
|
J-Bakuli
pushed a commit
to J-Bakuli/ignite
that referenced
this pull request
Oct 28, 2024
luchnikovbsk
pushed a commit
to luchnikovbsk/ignite
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryObjectExImpl::toString shouldn't try to generate large strings for large arrays and respect the IGNITE_TO_STRING_COLLECTION_LIMIT property.
Otherwise errors like java.lang.OutOfMemoryError: Requested array size exceeds VM limit errors may occur.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.