Ignite-24212 : SQL schema might not be merged on node join. #11824
Conversation
…ma_v2' into IGNITE-24212_Non-persistent_SQL_schema_v2 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java
Vladsz83
changed the title
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java
Outdated
Show resolved
Hide resolved
| afterTestsStopped(); | ||
|
|
||
| beforeTestsStarted(); |
There was a problem hiding this comment.
Looks weird, let's introduce new test class for this test
Also:
- the same problem can be reproduced on H2 engine.
- the same problem exists for persistent (if we clean persistent dir for testGrid after stopping)
There was a problem hiding this comment.
Hm. For H2 - yes, sure. This is a common schema sharing problem. For persistent cluster I checked without data erasing. Looks like works also for inactive cluster. Ok, for this cases a new test class would be more handy.
| if (!patchesToApply.isEmpty()) { | ||
| for (Map.Entry<DynamicCacheDescriptor, QuerySchemaPatch> entry : patchesToApply.entrySet()) { | ||
| if (entry.getKey().applySchemaPatch(entry.getValue()) && !isClusterActive) | ||
| saveCacheConfiguration(entry.getKey()); |
There was a problem hiding this comment.
Method saveCacheConfiguration also called from processJoiningNode without state check. Do we need to add this check to processJoiningNode too?
Why do we need state check at all? If it was stored on inactive cluster state in 2/3 of cases, perhaps, it should be stored in all cases? Does cache configuration stored after activation? For example, new node has joined the inactive persistent cluster. Cluster has caches with patches to apply. After activation cluster works some time and shutted down. Will new query entities be available on the new node if it will be started as first node?
There was a problem hiding this comment.
This is a good question about storing only on active cluster. I'll try to store every time.
Vladsz83
changed the title
...est/java/org/apache/ignite/internal/processors/cache/index/RejoinWithLostDynamicDdlTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/ignite/internal/processors/cache/index/RejoinWithLostDynamicDdlTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/ignite/internal/processors/cache/index/RejoinWithLostDynamicDdlTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/ignite/internal/processors/cache/index/RejoinWithLostDynamicDdlTest.java
Outdated
Show resolved
Hide resolved
|
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.