Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8497][VL] A bad test case that fails columnar table cache query #8498

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Jan 10, 2025

#8497

Add a bad case which is ignored at the moment to reproduce the bug described in #8497.

I am still looking for a proper solution of the bug. Could merge the test code in advance so one could try with it if interested.

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Jan 10, 2025
Copy link

#8497

@apache apache deleted a comment from github-actions bot Jan 10, 2025
@apache apache deleted a comment from github-actions bot Jan 10, 2025
@apache apache deleted a comment from github-actions bot Jan 10, 2025
Copy link

Run Gluten Clickhouse CI on x86

@zhztheplayer zhztheplayer marked this pull request as draft January 10, 2025 08:46
Copy link

Run Gluten Clickhouse CI on x86

@FelixYBW
Copy link
Contributor

Good catch. We need to have a way to automatically convert any columnar format to Velox format. Do we need to hack spark code to do the conversion?

@zhztheplayer zhztheplayer marked this pull request as ready for review January 11, 2025 02:51
@zhztheplayer
Copy link
Member Author

zhztheplayer commented Jan 11, 2025

Good catch. We need to have a way to automatically convert any columnar format to Velox format.

Yes, we already have the transition system to insert the convertions automaically in query planning phase. This bug specifically applies to columnar table cache feature since the conversions are expected to be done at execution time.

Do we need to hack spark code to do the conversion?

For fixing this issue, I am not sure yet. Will keep looking for solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants