Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
allow snapshot for downstream drools-ansible CI to avoid unnecessary …
…CI failures (#5464)
- Loading branch information
fe73ad5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkobayas why was that setup ?
I mean all snapshot artifacts should be built and not downloaded ...
fe73ad5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @radtriste , Thank you for taking a look.
I had raised the PR (https://github.com/kiegroup/drools/pull/5464) in order to avoid CI failures where
drools-ansible-rulebook-integration
specifies a hard-coded SNAPSHOT version (https://github.com/kiegroup/drools-ansible-rulebook-integration/blob/main/pom.xml#L33) and Drools repo bumps its version.For example, while
drools-ansible-rulebook-integration
specifies<version.drools>8.43.0-SNAPSHOT</version.drools>
,drools
main branch version is bumped to8.44.0-SNAPSHOT
. Thenpr-drools-ansible.yml
CI fails because it cannot download drools8.43.0-SNAPSHOT
. So we have to manually update thedrools-ansible-rulebook-integration/pom.xml
. It happens every time drools version is bumped.Once
drools-ansible-rulebook-integration/pom.xml
is updated to<version.drools>8.44.0-SNAPSHOT</version.drools>
, yes,8.44.0-SNAPSHOT
could be downloaded. But, the SNAPSHOT artifacts are also built and installed into the CI local repo, so aren't the newly built artifacts actually used?I tested if the
pr-drools-ansible.yml
CI can pick up the new commit in drools repo. Both projects are8.44.0-SNAPSHOT
andallow-snapshots: true
.https://github.com/kiegroup/drools/pull/5473
kiegroup/drools-ansible-rulebook-integration#74
The
pr-drools-ansible.yml
CI picks up the newly built artifacts which contains the new method in the drools PR commit (if not, it should fail with a compilation error). However, I'm not 100% confident if I'm doing a right thing. Please kindly share your thoughts on this. Thanks!fe73ad5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah ...
drools-ansible-rulebook-integration
is not part of the automation on cut-off and that is maybe the problem. we should think about that. In the meantime, this is indeed a workaround, even if I am not a big fan of it, because it could hide some module deps issues ...fe73ad5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radtriste Thanks! I sent an email about it to you, Mario and Daniele. Let's discuss there.