[incubator-kie-drools-6239] Review and update EmbeddedStorageManagerTest #6258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
commented
Feb 18, 2025
| assertThat(StorageManagerFactory.get().getStorageManager().getStorageNames()).contains(SESSION_STORAGE_PREFIX + "0_" + "epDefault", "METADATA_0"); | ||
| } | ||
|
|
||
| public static class FakeCacheManager extends DefaultCacheManager { |
There was a problem hiding this comment.
While trying to adapt the test code to meet Infinispan 15, I noticed that this FakeCacheManager quite depends on DefaultCacheManager, and it's not actually possible to write "Fake" class in this case. So changed to just use DefaultCacheManager .
RishiRajAnand
approved these changes
Feb 18, 2025
mariofusco
approved these changes
Feb 19, 2025
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Feb 19, 2025
…est (apache#6258) * [incubator-kie-drools-6239] Review and update EmbeddedStorageManagerTest * - fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: