-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1834] DMN: verify namespaces are always aligned #6259
base: main
Are you sure you want to change the base?
Conversation
It seems some dmn models start to fail validation in kogito-runtimes now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a PR @gitgabrio
...dmn/kie-dmn-backend/src/main/java/org/kie/dmn/backend/marshalling/v1x/XStreamMarshaller.java
Show resolved
Hide resolved
...dmn/kie-dmn-backend/src/main/java/org/kie/dmn/backend/marshalling/v1x/XStreamMarshaller.java
Show resolved
Hide resolved
@@ -22,7 +22,7 @@ | |||
xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" | |||
xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" | |||
xmlns:dmndi="https://www.omg.org/spec/DMN/20230324/DMNDI/" | |||
xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" | |||
xmlns:feel="https://www.omg.org/spec/DMN/20230324/FEEL/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this code change open a question in me, what should our tooling to do if an inconsistent namespaces are present in opened file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should ask the user a question if they want to update it and if they confirm, then Canvas could fix it for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DMN version is an atomic entity that comprise also FEEL, DMNDI, DI, and DC.
Even if they are defined under different namespaces for technical reason, as a matter of fact they are all part of the same version.
So, switching DMN version should imply that all of them are kept in sync with that version, otherwise the model will be in inconsistent state.
Fixes apache/incubator-kie-issues#1834
Needs: apache/incubator-kie-kogito-runtimes#3849
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdb
for Jenkins PR check only
Build Now
button.