Issue-405 Add external built image integrity validation #673
Conversation
|
🎊 PR Preview a9b6165 has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-673.surge.sh |
There was a problem hiding this comment.
@treblereel I appreciate the PR! Many thanks.
But I think we need a new section to explain how to build an image for the workflow using our Dockerfile as an inspiration.
And add examples of the directory structure, so people will understand better how to build and use that images in the deployments.
We can then use this new section as a reference to other places that we also need to review in this PR:
- https://sonataflow.org/serverlessworkflow/main/cloud/operator/build-and-deploy-workflows.html
- https://sonataflow.org/serverlessworkflow/main/cloud/operator/building-custom-images.html
Maybe instead of a new section you can break this last one (https://sonataflow.org/serverlessworkflow/main/cloud/operator/building-custom-images.html) in two and explain how to build the devmode and the gitops image.
| === Setting a custom image in devmode | ||
|
|
||
| In xref:cloud/operator/developing-workflows.adoc[development profile], it's expected that the image is based on the default `quay.io/kiegroup/kogito-swf-devmode:latest`. | ||
| In xref:cloud/operator/developing-workflows.adoc[development profile], it's expected that the image is based on the default `quay.io/kiegroup/kogito-swf-devmode:latest`. |
There was a problem hiding this comment.
@ricardozanini shouldn't this be the https://hub.docker.com/r/apache/incubator-kie-sonataflow-devmode url?
There was a problem hiding this comment.
There is a small question about URL for the devmode reference, but since we are lacking the overall update here I think we can fix that together in separate PR.
Edit: oh, @ricardozanini your comment didnt load for me :D makes sense, will check back when updated.
|
@domhanak As we agreed with @ricardozanini, I have to do much deeper docs than this PR (That is why I created an issue). So, this PR will be reworked (right after operator PR merged) |
apache/incubator-kie-kogito-serverless-operator#405