Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#470: Replace copyright headers/comments on kogito-examples as part of the migration to Apache #1817

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

pefernan
Copy link
Contributor

Closes apache/incubator-kie-issues#470

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

WARNING! Please make sure you are opening your PR against main branch!

  • You have read the contributors guide
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [kogito-examples] tests

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headers update PR, quite extensive and hard to manually review.

I scrolled a lot and all seemed correct, waiting now for green CI.

@pefernan
Copy link
Contributor Author

@porcelli yea I know... tbh I think there are some files that could be excluded (configs, properties, some xmls..)

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 10, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1817 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1817/1/display/redirect

Test results:

  • PASSED: 372
  • FAILED: 7

Those are the test failures:

org.kie.kogito.quarkus.outbox.OutboxIT.(?) org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8080, 35090] should be listening)
org.acme.travels.ApprovalsRestIT.testStartApprovalUnauthenticated Failed to load ApplicationContext
PR check / Build projects / org.acme.travels.ApprovalsRestIT.testStartApprovalAuthorized Failed to load ApplicationContext
org.kie.kogito.springboot.outbox.OutboxIT.(?) org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8080, 35137] should be listening)
org.acme.travels.ApprovalsProcessTestIT.testApprovalProcess Failed to load ApplicationContext
org.acme.travels.ApprovalsProcessTestIT.testApprovalProcessViaPhases Failed to load ApplicationContext
org.kie.kogito.examples.OpenVinoRestIT.testOpenvino 1 expectation failed.
Expected status code <201> but was <500>.

@pefernan pefernan marked this pull request as ready for review October 10, 2023 21:27
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjtirado I thought that removing this file would be nice :P

@pefernan pefernan changed the title WIP: kie-issues#470: Replace copyright headers/comments on kogito-examples as part of the migration to Apache kie-issues#470: Replace copyright headers/comments on kogito-examples as part of the migration to Apache Oct 13, 2023
@porcelli porcelli merged commit d524145 into apache:main Oct 13, 2023
1 check passed
@pefernan pefernan deleted the kie-issues/470 branch October 13, 2023 14:07
rgdoliveira pushed a commit to kiegroup/kogito-examples that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants