Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kie-issues#1564] Do not overwrite original jar with Spring Boot executable jar in integration tests #3748

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[kie-issues#1564] Do not overwrite original jar with Spring Boot executable jar in integration tests #3748

wants to merge 2 commits into from
+16 −1

Conversation

baldimir
Copy link
Contributor

Resolves apache/incubator-kie-issues#1564

  • Adds a classifier to Spring Boot executable jars in integration-tests.
  • Moves the unpack profile to an earlier Maven phase to make the unpacked classes available for code generation happening during compile phase.

jstastny-cz
jstastny-cz approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@baldimir
Copy link
Contributor Author

I will check the downstream fails tomorrow.

@baldimir baldimir force-pushed the move-unpack-to-different-phase branch from a7021c7 to e078797 Compare October 24, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstastny-cz jstastny-cz jstastny-cz approved these changes

@cimbalek cimbalek cimbalek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not overwrite original jar with Spring Boot executable jar in integration tests
3 participants
@baldimir @jstastny-cz @cimbalek