[incubator-kie-issues#1625] Connection leak in persistence jdbc common #3784
+18
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinweiler
approved these changes
Nov 19, 2024
pefernan
approved these changes
Nov 20, 2024
yesamer
changed the title
fjtirado
requested changes
Dec 13, 2024
| ResultSet resultSet = close.nest(statement.executeQuery()); | ||
| return StreamSupport.stream(new Spliterators.AbstractSpliterator<Record>( | ||
| Long.MAX_VALUE, Spliterator.ORDERED) { | ||
| List<Record> record = new ArrayList<>(); |
There was a problem hiding this comment.
Hi, the point of returning a stream was to not go through the whole list returned by the JDBC driver, avoiding a performance issue if the list of process instances is huge (notice that in the implementation being replaced you do not have to build the whole list of records )
Cant we fix the leak in closeablewrapper (whatever is it, maybe onclose is not invoked always?) without changing this part? I think we are going back to former implementaiton that provokes performance issues when the list of process instances grow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1625