Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#667: fix cleanup and settingsXml handling #613

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

jstastny-cz
Copy link

@jstastny-cz jstastny-cz commented Nov 1, 2023

apache/incubator-kie-issues#667

Fixing cleanup and settings.xml pipeline configuration to work correctly in ASF Jenkins.

  • Deferred wipeout was causing issues when invoked in early stages
  • Docker cleanup can't be done since the overall build is in docker container that uses the docker.sock from the host - it would attempt to erase itself.
  • withSettingsXmlId shared library method does imply usage of a prohibited groovy method, thus replacing with explicit configFileProvider and passing as withSettingsXmlFile goes around that part of code.

Complete list:
apache/incubator-kie-kogito-pipelines#1113
apache/incubator-kie-kogito-runtimes#3272
apache/incubator-kie-kogito-apps#1909
apache/incubator-kie-kogito-examples#1820
apache/incubator-kie-drools#5572
apache/incubator-kie-optaplanner#3010
#613
apache/incubator-kie-kogito-docs#514
apache/incubator-kie-docs#4531
apache/incubator-kie-benchmarks#273

@baldimir baldimir merged commit 2fa17ef into apache:8.x Nov 2, 2023
0 of 8 checks passed
jstastny-cz added a commit to jstastny-cz/incubator-kie-optaplanner-quickstarts that referenced this pull request Jul 25, 2024
* kie-issues#667: fix cleanup and settingsXml handling

* adjust also MavenCommands passed to maven library methods

---------

Co-authored-by: jstastny-cz <[email protected]>
lucamolteni pushed a commit to jstastny-cz/incubator-kie-optaplanner-quickstarts that referenced this pull request Jul 26, 2024
* kie-issues#667: fix cleanup and settingsXml handling

* adjust also MavenCommands passed to maven library methods

---------

Co-authored-by: jstastny-cz <[email protected]>
lucamolteni pushed a commit that referenced this pull request Jul 26, 2024
* kie-issues#574 Initial ASF Jenkins CI Setup (#607)

Co-authored-by: jstastny-cz <[email protected]>

* kie-issues#587 abort stale builds (#608)

Co-authored-by: jstastny-cz <[email protected]>

* kie-issues#643: fix PR check buildchain configuration

* kie-issues#667: fix cleanup and settingsXml handling (#613)

* kie-issues#667: fix cleanup and settingsXml handling

* adjust also MavenCommands passed to maven library methods

---------

Co-authored-by: jstastny-cz <[email protected]>

* 8.x kie-issues#674: update GHA references (#614)

* kie-issues#674: update GHA references

* change surefire action

---------

Co-authored-by: jstastny-cz <[email protected]>

* kie-issues#727: define push GH tokens for jenkins

* 8.x kie-issues#767: set user config for git

* NO-ISSUE: fix docker agent config

* NO-ISSUE: adjust branch mapping

* NO-ISSUE: apache transfer leftovers

* parameterize buildchain file url

---------

Co-authored-by: jstastny-cz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants