Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#654: simplify buildchain configuration #3005

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jstastny-cz
Copy link
Contributor

apache/incubator-kie-issues#654

Simplifying build-chain project configuration, so that there's a direct mapping between matching branches in optaplanner and optaplanner-quickstarts.
Does remove the need for MIGRATE_TO_9 env variable and handling.

Should be considered as unblocking the non-working PR checks at the moment, with assumption this logic would be brought back when needed.

@jstastny-cz
Copy link
Contributor Author

Running check is not relevant to the changes made - it still takes the config from apache:main.

@radtriste
Copy link
Contributor

tested locally

# Checkout summary
[INFO] [apache/incubator-kie-optaplanner]
[INFO] 	 Project taken from apache/incubator-kie-optaplanner:main (Branch HEAD 28bbb032e63f42a7220e04dbc6ce3f9ea9041a9c)
[INFO] 	 Merged jstastny-cz/optaplanner:kie-issues_654 into branch main
[INFO] [apache/incubator-kie-optaplanner-quickstarts]
[INFO] 	 Project taken from apache/incubator-kie-optaplanner-quickstarts:8.x (Branch HEAD e6d53a1fd95d64e0d9bf8be676fef0657c159dca)

@jstastny-cz all good to me !

@jstastny-cz
Copy link
Contributor Author

Ok, I will investigate if build-chain has issue resolving the URL because of my fork having different name that the target repository.

@jstastny-cz jstastny-cz merged commit 16daa2c into apache:main Oct 26, 2023
1 check was pending
@jstastny-cz jstastny-cz deleted the kie-issues_654 branch October 26, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants