kie-issues#2659: [SonataFlow] Migrate DBMigration Image from SonataFlow operator repository to kie-tools #2697
+1,413
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
requested changes
Oct 22, 2024
|
|
||
| labels: | ||
| - name: "org.kie.kogito.version" | ||
| value: "999-SNAPSHOT" |
There was a problem hiding this comment.
Suggested change
| value: "999-SNAPSHOT" | |
| value: "### SET ME DURING BUILD PROCESS ###" |
packages/kogito-db-migrator-tool-image/cekit/modules/kogito-postgres-db-migration-deps/install
Show resolved
Hide resolved
...ges/kogito-db-migrator-tool/src/main/cekit/modules/kogito-postgres-db-migration-deps/install
Show resolved
Hide resolved
...ogito-db-migrator-tool/src/main/cekit/modules/kogito-postgres-db-migration-deps/migration.sh
Show resolved
Hide resolved
tiagobento
requested changes
Oct 22, 2024
Comment on lines
+26
to
+28
| devDeploymentQuarkusApp: { | ||
| version: require("../package.json").version, | ||
| }, |
Comment on lines
+28
to
+29
| -Dversion.quarkus=${env.versions.quarkus} | ||
| -Dversion.org.kie.kogito=${env.versions.kogito} |
There was a problem hiding this comment.
We don't need those here, as they come from maven-base already.
Comment on lines
+16
to
+17
| "build:dev": "./build-db-migrator-jar.sh true", | ||
| "build:prod": "./build-db-migrator-jar.sh false", |
There was a problem hiding this comment.
These commands add an unnecessary indirection and don't work on Windows.
There was a problem hiding this comment.
Why do you need so many things here?
Comment on lines
+25
to
+26
| DDL_VERSION=10.0.999-SNAPSHOT | ||
| DDL_FILE=kogito-ddl-10.0.999-20241018.012042-73-db-scripts.zip |
There was a problem hiding this comment.
This needs to be parameterized.
| { ignoreDefault: true } // Can't have special <repositories> configuration that only works inside this repo. | ||
| ); | ||
|
|
||
| installMvnw(); |
There was a problem hiding this comment.
I don't think you need mvnw here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2659
Add kogito-db-migrator-tool and kogito-db-migrator-tool-image packages for use by the SonataFlow Operator.