[to rc/1.3.3] Make procedure scheduler ignore successful procedure (#…

…13330)

* we just ignore it, ok?

* don't add back successful procedure

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java

@@ -237,7 +237,7 @@ public void deserialize(ByteBuffer byteBuffer) {
       byte[] resultArr = new byte[resultLen];
       byteBuffer.get(resultArr);
     }
-    //  has  lock
+    //  has lock
     if (byteBuffer.get() == 1) {
       this.lockedWhenLoading();
     }

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java

@@ -400,8 +400,11 @@ private void executeProcedure(Procedure<Env> proc) {
    * @param proc procedure
    */
   private void executeProcedure(RootProcedureStack rootProcStack, Procedure<Env> proc) {
-    Preconditions.checkArgument(
-        proc.getState() == ProcedureState.RUNNABLE, "NOT RUNNABLE! " + proc);
+    if (proc.getState() != ProcedureState.RUNNABLE) {
+      LOG.error(
+          "The executing procedure should in RUNNABLE state, but it's not. Procedure is {}", proc);
+      return;
+    }
     boolean suspended = false;
     boolean reExecute;
 

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/scheduler/AbstractProcedureScheduler.java

@@ -78,6 +78,10 @@ public void signalAll() {
 
   @Override
   public void addFront(final Procedure procedure) {
+    if (procedure.isSuccess()) {
+      LOG.warn("Don't add a successful procedure back to the scheduler, it will be ignored");
+      return;
+    }
     push(procedure, true, true);
   }
 
@@ -88,6 +92,10 @@ public void addFront(final Procedure procedure, boolean notify) {
 
   @Override
   public void addBack(final Procedure procedure) {
+    if (procedure.isSuccess()) {
+      LOG.warn("Don't add a successful procedure back to the scheduler, it will be ignored");
+      return;
+    }
     push(procedure, false, true);
   }