Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize UT/IT of rest api #12708

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Optimize UT/IT of rest api #12708

wants to merge 7 commits into from

Conversation

HTHou
Copy link
Contributor

@HTHou HTHou commented Jun 11, 2024

Description

@HTHou HTHou marked this pull request as draft June 11, 2024 10:27
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 23.72881% with 90 lines in your changes missing coverage. Please review.

Project coverage is 41.81%. Comparing base (7a389dd) to head (6daa39d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../db/protocol/rest/utils/InsertTabletDataUtils.java 26.74% 63 Missing ⚠️
.../rest/v1/handler/StatementConstructionHandler.java 0.00% 8 Missing ⚠️
.../rest/v2/handler/StatementConstructionHandler.java 41.66% 7 Missing ⚠️
...tdb/db/protocol/rest/utils/InsertRowDataUtils.java 0.00% 6 Missing ⚠️
...b/db/protocol/rest/v1/impl/RestApiServiceImpl.java 0.00% 3 Missing ⚠️
...b/db/protocol/rest/v2/impl/RestApiServiceImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12708      +/-   ##
============================================
+ Coverage     41.78%   41.81%   +0.02%     
  Complexity       71       71              
============================================
  Files          3974     3974              
  Lines        246887   246824      -63     
  Branches      29907    29890      -17     
============================================
+ Hits         103159   103203      +44     
+ Misses       143728   143621     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant