Fix memory calculate error when insertRecords with both aligned and non-aligned devices #12720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-aligned devices
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12720 +/- ##
=========================================
Coverage 41.74% 41.75%
Complexity 71 71
=========================================
Files 3973 3973
Lines 246793 246816 +23
Branches 29894 29901 +7
=========================================
+ Hits 103032 103062 +30
+ Misses 143761 143754 -7 ☔ View full report in Codecov by Sentry. |
jt2594838
requested changes
Jun 14, 2024
...ode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
Outdated
Show resolved
Hide resolved
...ode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
Outdated
Show resolved
Hide resolved
...ode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
Outdated
Show resolved
Hide resolved
...ode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
Outdated
Show resolved
Hide resolved
...ode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
Outdated
Show resolved
Hide resolved
...ode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessorTest.java
Show resolved
Hide resolved
|
jt2594838
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For an InsertRowsNode, we cannot ensure it only contains one alignment type of InsertRowNode.
Pipe may generate the InsertRowsNode like that.