Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression request of InsertRecords in Java client #12784

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

THUMarkLau
Copy link
Contributor

@THUMarkLau THUMarkLau commented Jun 21, 2024

This PR redesigned the serialization method of the InsertRecords write request, making the size of the serialized InsertRecords request smaller, thus saving network throughput.

Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0.46512% with 428 lines in your changes missing coverage. Please review.

Project coverage is 41.70%. Comparing base (df68083) to head (61c3316).
Report is 7 commits behind head on master.

Files Patch % Lines
.../isession/util/InsertRecordsReqSerializeUtils.java 0.00% 397 Missing ⚠️
...pache/iotdb/isession/req/InsertRecordsRequest.java 0.00% 30 Missing ⚠️
.../db/protocol/thrift/impl/ClientRPCServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12784      +/-   ##
============================================
- Coverage     41.80%   41.70%   -0.10%     
  Complexity       71       71              
============================================
  Files          3301     3304       +3     
  Lines        208401   208909     +508     
  Branches      24757    24810      +53     
============================================
+ Hits          87121    87128       +7     
- Misses       121280   121781     +501     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants