Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding cluster name to metrics #12786

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

SpriCoder
Copy link
Contributor

Binding cluster name to metrics

Copy link

sonarcloud bot commented Jun 21, 2024

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.78%. Comparing base (e58d427) to head (65de7d8).
Report is 4 commits behind head on master.

Files Patch % Lines
...he/iotdb/confignode/conf/ConfigNodeDescriptor.java 0.00% 1 Missing ⚠️
.../org/apache/iotdb/metrics/config/MetricConfig.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12786      +/-   ##
============================================
- Coverage     41.79%   41.78%   -0.01%     
  Complexity       71       71              
============================================
  Files          3302     3302              
  Lines        208481   208483       +2     
  Branches      24758    24752       -6     
============================================
- Hits          87128    87125       -3     
- Misses       121353   121358       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit b1e9d96 into master Jun 21, 2024
38 of 40 checks passed
@SpriCoder SpriCoder deleted the fix/metric-cluster-name branch June 21, 2024 11:02
JackieTien97 pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants