Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To rc/1.3.3] Refactor/ai node build update #13349

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

ycycse
Copy link
Member

@ycycse ycycse commented Aug 29, 2024

No description provided.

chrisdutz and others added 2 commits August 29, 2024 22:06
* fix: Hopefully fixed the build of the cpp-example on windows systems

* fix: Increase the timeout even more to finally make the build succeed.

* fix: Fix the build.

* refactor: Cleaned up the build of the ai-node to be more robust

* fix: Made the groovy script also work when building the entire project.

* feat: Added some checks to validate the min and max version of the python3 version being used.

* feat: Added some checks to validate the min and max version of the python3 version being used.

* fix: Updated the python settings in pyproject.toml to reflect the really valid range of python versions and updated the prerequisite check accordingly.

* feat: Removed the option to remove an AI node by rpc-ip+port.

* chore: Added the poetry.lock to the .gitignore

* docs: Removed the option to use the ip+port from the output of the scripts.

* chore: Added the poetry.lock to the repo and removed it from the .gitignore file

(cherry picked from commit 7c808c5)
@SteveYurongSu SteveYurongSu self-assigned this Aug 29, 2024
Copy link

sonarcloud bot commented Aug 29, 2024

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.48%. Comparing base (6cc25dd) to head (6e03157).
Report is 4 commits behind head on rc/1.3.3.

Additional details and impacted files
@@             Coverage Diff             @@
##             rc/1.3.3   #13349   +/-   ##
===========================================
  Coverage       41.47%   41.48%           
  Complexity         71       71           
===========================================
  Files            3434     3434           
  Lines          218617   218617           
  Branches        25993    25993           
===========================================
+ Hits            90679    90698   +19     
+ Misses         127938   127919   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveYurongSu SteveYurongSu merged commit bde8d66 into rc/1.3.3 Aug 29, 2024
30 of 31 checks passed
@SteveYurongSu SteveYurongSu deleted the cpAINodeRefactor branch August 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants