Add or modify encryption related codes #13364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jt2594838
approved these changes
Sep 2, 2024
Comment on lines
123
to
126
| public static void setUp() throws Exception { | ||
| TSFileDescriptor.getInstance().getConfig().setEncryptFlag("true"); | ||
| TSFileDescriptor.getInstance().getConfig().setEncryptType("AES128"); | ||
| TSFileDescriptor.getInstance().getConfig().setEncryptKey("mkmkmkmkmkmkmkmk"); |
There was a problem hiding this comment.
This will not be effective for the testing environment because the servers are started in another process.
Refer to EnvFactory.getEnv().getConfig() to see how to change the config in IT.
There was a problem hiding this comment.
The loading TsFiles cases should be tested. Either loading a TsFile with consistent encryption, or with unrecognized encryption.
Comment on lines
113
to
135
| public static ByteBuffer decryptAndUncompressPageData( | ||
| PageHeader pageHeader, | ||
| IUnCompressor unCompressor, | ||
| ByteBuffer compressedPageData, | ||
| IDecryptor decryptor) | ||
| throws IOException { | ||
| int compressedPageBodyLength = pageHeader.getCompressedSize(); | ||
| byte[] uncompressedPageData = new byte[pageHeader.getUncompressedSize()]; | ||
| try { | ||
| byte[] decryptedPageData = | ||
| decryptor.decrypt(compressedPageData.array(), 0, compressedPageBodyLength); | ||
| unCompressor.uncompress( | ||
| decryptedPageData, 0, compressedPageBodyLength, uncompressedPageData, 0); | ||
| } catch (Exception e) { | ||
| throw new IOException( | ||
| "Decrypt and Uncompress error! uncompress size: " | ||
| + pageHeader.getUncompressedSize() | ||
| + "compressed size: " | ||
| + pageHeader.getCompressedSize() | ||
| + "page header: " | ||
| + pageHeader | ||
| + e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Avoid coying when not encrypted or compressed like those in TsFile.
Comment on lines
127
to
134
| throw new IOException( | ||
| "Decrypt and Uncompress error! uncompress size: " | ||
| + pageHeader.getUncompressedSize() | ||
| + "compressed size: " | ||
| + pageHeader.getCompressedSize() | ||
| + "page header: " | ||
| + pageHeader | ||
| + e.getMessage()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add or modify encryption related codes for encryption module realization.