Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate metadata memory when estimate compaction task memory #13404

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,33 @@ public ByteBuffer readPageWithoutUnCompressing(long startOffset, int pageSize)
return timeseriesMetadataOffsetMap;
}

public Map<String, Pair<Long, Long>> getTimeseriesMetadataOffsetByDevice(
MetadataIndexNode measurementNode) throws IOException {
Map<String, Pair<Long, Long>> timeseriesMetadataOffsetMap = new LinkedHashMap<>();
List<IMetadataIndexEntry> childrenEntryList = measurementNode.getChildren();
for (int i = 0; i < childrenEntryList.size(); i++) {
long startOffset = childrenEntryList.get(i).getOffset();
long endOffset =
i == childrenEntryList.size() - 1
? measurementNode.getEndOffset()
: childrenEntryList.get(i + 1).getOffset();
if (measurementNode.getNodeType().equals(MetadataIndexNodeType.LEAF_MEASUREMENT)) {
// leaf measurement node
timeseriesMetadataOffsetMap.put(
childrenEntryList.get(i).getCompareKey().toString(),
new Pair<>(startOffset, endOffset));
} else {
// internal measurement node
ByteBuffer nextBuffer = readData(startOffset, endOffset);
MetadataIndexNode nextLayerMeasurementNode =
getDeserializeContext().deserializeMetadataIndexNode(nextBuffer, false);
timeseriesMetadataOffsetMap.putAll(
getTimeseriesMetadataOffsetByDevice(nextLayerMeasurementNode));
}
}
return timeseriesMetadataOffsetMap;
}

private void acquireReadDataSizeWithCompactionReadRateLimiter(int readDataSize) {
CompactionTaskManager.getInstance().getCompactionReadOperationRateLimiter().acquire(1);
CompactionTaskManager.getInstance().getCompactionReadRateLimiter().acquire(readDataSize);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@
package org.apache.iotdb.db.storageengine.dataregion.compaction.selector.estimator;

import org.apache.iotdb.db.conf.IoTDBDescriptor;
import org.apache.iotdb.db.storageengine.dataregion.compaction.io.CompactionTsFileReader;
import org.apache.iotdb.db.storageengine.dataregion.compaction.schedule.constant.CompactionType;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;
import org.apache.iotdb.db.storageengine.rescon.memory.SystemInfo;

import org.apache.tsfile.file.metadata.ChunkMetadata;
import org.apache.tsfile.file.metadata.IDeviceID;
import org.apache.tsfile.file.metadata.MetadataIndexNode;
import org.apache.tsfile.read.TsFileDeviceIterator;
import org.apache.tsfile.read.TsFileSequenceReader;
import org.apache.tsfile.utils.Pair;
Expand Down Expand Up @@ -97,6 +100,48 @@ public static FileInfo calculateFileInfo(TsFileSequenceReader reader) throws IOE
averageChunkMetadataSize);
}

public static long roughEstimateMetadataCostInCompaction(
List<TsFileResource> resources, CompactionType taskType) throws IOException {
if (!CompactionEstimateUtils.addReadLock(resources)) {
return -1L;
}
long cost = -1L;
long modsFileSize = 0L;
try {
for (TsFileResource resource : resources) {
if (resource.modFileExists()) {
modsFileSize += resource.getModFile().getSize();
}
try (CompactionTsFileReader reader =
new CompactionTsFileReader(resource.getTsFilePath(), taskType)) {
cost = Math.max(cost, getMaxTimeseriesMetadataOfOneDeviceSize(reader));
}
}
return cost + modsFileSize;
} finally {
CompactionEstimateUtils.releaseReadLock(resources);
}
}

public static long getMaxTimeseriesMetadataOfOneDeviceSize(CompactionTsFileReader reader)
throws IOException {
TsFileDeviceIterator deviceIterator = reader.getAllDevicesIteratorWithIsAligned();
long maxSize = 0;
while (deviceIterator.hasNext()) {
deviceIterator.next();
MetadataIndexNode firstMeasurementNodeOfCurrentDevice =
deviceIterator.getFirstMeasurementNodeOfCurrentDevice();
long totalTimeseriesMetadataSizeOfCurrentDevice = 0;
Map<String, Pair<Long, Long>> timeseriesMetadataOffsetByDevice =
reader.getTimeseriesMetadataOffsetByDevice(firstMeasurementNodeOfCurrentDevice);
for (Pair<Long, Long> offsetPair : timeseriesMetadataOffsetByDevice.values()) {
totalTimeseriesMetadataSizeOfCurrentDevice += (offsetPair.right - offsetPair.left);
}
maxSize = Math.max(maxSize, totalTimeseriesMetadataSizeOfCurrentDevice);
}
return maxSize;
}

public static boolean shouldAccurateEstimate(long roughEstimatedMemCost) {
return roughEstimatedMemCost > 0
&& IoTDBDescriptor.getInstance().getConfig().getCompactionThreadCount()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.apache.iotdb.db.storageengine.dataregion.compaction.selector.estimator;

import org.apache.iotdb.db.storageengine.dataregion.compaction.schedule.constant.CompactionType;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;

import java.io.IOException;
Expand Down Expand Up @@ -80,6 +81,15 @@ public long calculatingDataMemoryCost(CompactionTaskInfo taskInfo) throws IOExce
@Override
public long roughEstimateInnerCompactionMemory(List<TsFileResource> resources)
throws IOException {
long metadataCost =
CompactionEstimateUtils.roughEstimateMetadataCostInCompaction(
resources,
resources.get(0).isSeq()
? CompactionType.INNER_SEQ_COMPACTION
: CompactionType.INNER_UNSEQ_COMPACTION);
if (metadataCost < 0) {
return metadataCost;
}
int maxConcurrentSeriesNum =
Math.max(
config.getCompactionMaxAlignedSeriesNumInOneBatch(), config.getSubCompactionTaskNum());
Expand All @@ -89,6 +99,7 @@ public long roughEstimateInnerCompactionMemory(List<TsFileResource> resources)
// source files (chunk + uncompressed page) * overlap file num
// target file (chunk + unsealed page writer)
return (maxOverlapFileNum + 1) * maxConcurrentSeriesNum * (maxChunkSize + maxPageSize)
+ memoryBudgetForFileWriter;
+ memoryBudgetForFileWriter
+ metadataCost;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.apache.iotdb.db.storageengine.dataregion.compaction.selector.estimator;

import org.apache.iotdb.db.storageengine.dataregion.compaction.schedule.constant.CompactionType;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;

import java.io.IOException;
Expand Down Expand Up @@ -85,6 +86,14 @@ public long roughEstimateCrossCompactionMemory(
List<TsFileResource> sourceFiles = new ArrayList<>(seqResources.size() + unseqResources.size());
sourceFiles.addAll(seqResources);
sourceFiles.addAll(unseqResources);

long metadataCost =
CompactionEstimateUtils.roughEstimateMetadataCostInCompaction(
sourceFiles, CompactionType.CROSS_COMPACTION);
if (metadataCost < 0) {
return metadataCost;
}

int maxConcurrentSeriesNum =
Math.max(
config.getCompactionMaxAlignedSeriesNumInOneBatch(), config.getSubCompactionTaskNum());
Expand All @@ -94,6 +103,7 @@ public long roughEstimateCrossCompactionMemory(
// source files (chunk + uncompressed page) * overlap file num
// target files (chunk + unsealed page writer)
return (maxOverlapFileNum + 1) * maxConcurrentSeriesNum * (maxChunkSize + maxPageSize)
+ memoryBudgetForFileWriter;
+ memoryBudgetForFileWriter
+ metadataCost;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@

package org.apache.iotdb.db.storageengine.dataregion.compaction.selector.estimator;

import org.apache.iotdb.db.storageengine.dataregion.compaction.schedule.constant.CompactionType;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;

import java.io.IOException;
import java.util.List;

public class ReadChunkInnerCompactionEstimator extends AbstractInnerSpaceEstimator {
Expand Down Expand Up @@ -71,14 +73,23 @@ public long calculatingDataMemoryCost(CompactionTaskInfo taskInfo) {
}

@Override
public long roughEstimateInnerCompactionMemory(List<TsFileResource> resources) {
public long roughEstimateInnerCompactionMemory(List<TsFileResource> resources)
throws IOException {
long metadataCost =
CompactionEstimateUtils.roughEstimateMetadataCostInCompaction(
resources, CompactionType.INNER_SEQ_COMPACTION);
if (metadataCost < 0) {
return metadataCost;
}
int maxConcurrentSeriesNum =
Math.max(
config.getCompactionMaxAlignedSeriesNumInOneBatch(), config.getSubCompactionTaskNum());
long maxChunkSize = config.getTargetChunkSize();
long maxPageSize = tsFileConfig.getPageSizeInByte();
// source files (chunk + uncompressed page)
// target file (chunk + unsealed page writer)
return 2 * maxConcurrentSeriesNum * (maxChunkSize + maxPageSize) + memoryBudgetForFileWriter;
return 2 * maxConcurrentSeriesNum * (maxChunkSize + maxPageSize)
+ memoryBudgetForFileWriter
+ metadataCost;
}
}
Loading