Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error in aggregation merge sort when device locates in multi data regions #13620

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Sep 25, 2024

Description

As the title, when one device locates in multi data regions, the query result may be wrong.

image


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.45%. Comparing base (5b22e7b) to head (960c8ca).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
...ueryengine/plan/planner/OperatorTreeGenerator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13620      +/-   ##
============================================
- Coverage     41.55%   41.45%   -0.11%     
  Complexity       71       71              
============================================
  Files          3986     3994       +8     
  Lines        247640   248213     +573     
  Branches      30030    30108      +78     
============================================
- Hits         102905   102893      -12     
- Misses       144735   145320     +585     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 9903702 into master Sep 25, 2024
27 of 29 checks passed
@Beyyes Beyyes deleted the beyyes/fix_agg_merge_sort branch September 26, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants