Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected column order in ExportTsFile when wildcard is not used #13662

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jt2594838
Copy link
Contributor

The ExportTsFile tool expects the columns in the result set to be ordered by Device.

However, it is not guaranteed when a wildcard is not used in the SELECT clause (e.g., SELECT s_3, s_9 FROM root.db.**).

In this PR, the assumption of column order is removed, and the construction of Tablets will be based on the actual order of the result set.

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 41.39%. Comparing base (6742d4b) to head (af6e4fc).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...ava/org/apache/iotdb/tool/tsfile/ExportTsFile.java 0.00% 70 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13662      +/-   ##
============================================
- Coverage     41.41%   41.39%   -0.02%     
  Complexity       71       71              
============================================
  Files          3997     4002       +5     
  Lines        248717   249012     +295     
  Branches      30200    30226      +26     
============================================
+ Hits         103007   103081      +74     
- Misses       145710   145931     +221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jt2594838 jt2594838 merged commit 8fca51a into master Sep 30, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants