Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_by and first_by aggregation support for table model #13822

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Oct 18, 2024

Description

As the tile. Support last_by(x, y) and first_by(x, y) aggregation function.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0.99668% with 596 lines in your changes missing coverage. Please review.

Project coverage is 40.17%. Comparing base (51bce33) to head (45e3af3).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...rce/relational/aggregation/FirstByAccumulator.java 0.00% 271 Missing ⚠️
...urce/relational/aggregation/LastByAccumulator.java 0.00% 270 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 0.00% 20 Missing ⚠️
...rce/relational/aggregation/AccumulatorFactory.java 0.00% 18 Missing ⚠️
...yengine/plan/relational/sql/parser/AstBuilder.java 41.66% 7 Missing ⚠️
...ource/relational/aggregation/FirstAccumulator.java 0.00% 2 Missing ⚠️
...ne/plan/relational/metadata/TableMetadataImpl.java 33.33% 2 Missing ⚠️
.../source/relational/aggregation/AvgAccumulator.java 0.00% 1 Missing ⚠️
...ource/relational/aggregation/CountAccumulator.java 0.00% 1 Missing ⚠️
...source/relational/aggregation/LastAccumulator.java 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13822      +/-   ##
============================================
- Coverage     40.33%   40.17%   -0.16%     
  Complexity       71       71              
============================================
  Files          4106     4125      +19     
  Lines        258340   259624    +1284     
  Branches      31525    31681     +156     
============================================
+ Hits         104191   104301     +110     
- Misses       154149   155323    +1174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Beyyes Beyyes changed the title Add last by aggregation support Add last_by and first_by aggregation support for table model Oct 18, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
44.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@JackieTien97 JackieTien97 merged commit 48593d7 into master Oct 18, 2024
29 of 31 checks passed
@JackieTien97 JackieTien97 deleted the add_max_min_support branch October 18, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants