Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation problem in first_by aggregation of table model #13834

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Oct 19, 2024

Description

As the title.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Beyyes Beyyes changed the title Fix calculation problem in first_by aggregation Fix calculation problem in first_by aggregation of table model Oct 19, 2024
Copy link

sonarcloud bot commented Oct 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 39.97%. Comparing base (a6cd2b0) to head (1540f53).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rce/relational/aggregation/FirstByAccumulator.java 0.00% 23 Missing ⚠️
...urce/relational/aggregation/LastByAccumulator.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #13834   +/-   ##
=========================================
  Coverage     39.96%   39.97%           
  Complexity       71       71           
=========================================
  Files          4144     4144           
  Lines        261744   261744           
  Branches      31902    31902           
=========================================
+ Hits         104607   104624   +17     
+ Misses       157137   157120   -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 37fe386 into master Oct 19, 2024
30 of 31 checks passed
@JackieTien97 JackieTien97 deleted the fix_first_by_bug branch October 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants