Skip to content

Commit

Permalink
Edit javadoc, address warnings.
Browse files Browse the repository at this point in the history
  • Loading branch information
afs committed Jan 15, 2025
1 parent 6acbea2 commit ff98ccf
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ private static void processExtends(List<OpExtend> ext, BiConsumer<Var, Expr> act

private static void processAssigns(List<OpAssign> assigns, BiConsumer<Var, Expr> action) {
assigns.forEach(assign->{
assign.getVarExprList().forEachExpr(action) ;
assign.getVarExprList().forEachVarExpr(action) ;
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public static void walk(VarExprList varExprList, ExprVisitor exprVisitor) {
public static void walk(VarExprList varExprList, OpVisitor opVisitor, ExprVisitor exprVisitor) {
if ( varExprList == null )
return;
varExprList.forEachExpr((v,e)->walk(e,opVisitor, exprVisitor));
varExprList.forEachExpr((v,e)->walk(e, opVisitor, exprVisitor));
}

private static OpVisitor nullOpVisitor = new OpVisitorBase();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public Map<Var, Expr> getExprs() {
/**
* Call the action for each (variable, expression) defined.
* Not called when there is no expression, just a variable.
* (c.f. {@link #forEachVarExpr}). Not order preserving.
* (c.f. {@link #forEachVarExpr}).
*/
public void forEachExpr(BiConsumer<Var, Expr> action) {
exprs.forEach(action);
Expand All @@ -75,8 +75,6 @@ public void forEachExpr(BiConsumer<Var, Expr> action) {
/**
* Call the action for each variable, in order.
* The expression may be null.
* Called when there is no expression, just a variable (c.f.
* {@link #forEachExpr}).
*/
public void forEachVarExpr(BiConsumer<Var, Expr> action) {
// * See {@link #forEach}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

/**
* Group aggregation functions calculated a value during grouping and placed in the
* output binding. This class is relationship of an aggregation expression and that
* output binding. This class is the relationship of an aggregation expression and that
* variable. Evaluation returns the variable's bound value.
*/

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
import org.apache.jena.sparql.syntax.ElementPathBlock;
import org.apache.jena.sparql.syntax.ElementTriplesBlock;

/** An {@link ElementTransform} which replaces occurrences of a variable with a Node value.
/**
* An {@link ElementTransform} which replaces occurrences of a variable with a Node value.
* Because a {@link Var} is a subclass of {@link Node_Variable} which is a {@link Node},
* this includes variable renaming.
* <p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ public void testGetCoordinate_3DSpatial_0DMeasure() {
@Test
public void testGetCoordinate_3DSpatial_1DMeasure() {
CustomCoordinateSequence sequence = new CustomCoordinateSequence(CoordinateSequenceDimensions.XYZM, "1 1 1 1, 2 2 2 2, 3 3 3 3");
System.out.println(sequence);
Coordinate coord = new CoordinateXYZM();
int index = 1;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ interface MutableModel<R extends Model> extends Model {
* @param listener {@link ModelChangedListener}, not null
* @return this model, for cascading
*/
@Override
R register(ModelChangedListener listener);

/**
Expand All @@ -131,6 +132,7 @@ interface MutableModel<R extends Model> extends Model {
*
* @param listener {@link ModelChangedListener}, not null
*/
@Override
R unregister(ModelChangedListener listener);

/**
Expand All @@ -141,5 +143,6 @@ interface MutableModel<R extends Model> extends Model {
* @see ModelChangedListener
* @see org.apache.jena.graph.GraphEvents
*/
@Override
R notifyEvent(Object event);
}
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ private static QueryIterator plainExecute(Op op, QueryIterator input, ExecutionC
// The Op may be a sequence due to TransformFilterPlacement
// so we need to do a full execution step, not go straight to the SolverLib.

ExecutionContext ec2 = new ExecutionContext(execCxt);
ExecutionContext ec2 = ExecutionContext.copy(execCxt);
ec2.setExecutor(plainFactory);

// Solve without going through this executor again.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ private static QueryIterator plainExecute(Op op, QueryIterator input, ExecutionC
// The Op may be a sequence due to TransformFilterPlacement
// so we need to do a full execution step, not go straight to the SolverLib.

ExecutionContext ec2 = new ExecutionContext(execCxt);
ExecutionContext ec2 = ExecutionContext.copy(execCxt);
ec2.setExecutor(plainFactory);

// Solve without going through this executor again.
Expand Down

0 comments on commit ff98ccf

Please sign in to comment.