KIP-1028: AK 3.8.0 Docker Official Image Assets #16768
Conversation
| for server in ha.pool.sks-keyservers.net $(shuf -e \ | ||
| hkp://p80.pool.sks-keyservers.net:80 \ | ||
| keyserver.ubuntu.com \ | ||
| hkp://keyserver.ubuntu.com:80 \ | ||
| pgp.mit.edu \ | ||
| hkp://keys.openpgp.org) ; do \ | ||
| gpg --batch --keyserver "$server" --recv-keys "$GPG_KEY" && break || : ; \ | ||
| done && \ |
There was a problem hiding this comment.
See the first example under https://github.com/docker-library/official-images?tab=readme-ov-file#image-build
There was a problem hiding this comment.
Thanks for the review @whalelines !
I went through the example, and made relevant changes to the Dockerfile:
- used GNUPGHOME
- Used only 2 keyservers - hkp://keys.openpgp.org and keyserver.ubuntu.com and removed the rest outdated keyservers
- Hardcoded the GPG_KEY inside the command itself
- Like flink-docker, used the practice of adding
gpgconf --kill allas part of verification commands. - wget uses kafka_url env variable, which downloads from a https source
Please let us know if these changes are okay, and if any more are needed.
Thank you again!
|
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
|
This PR is to be kept open as Docker Official Image PR is waiting on review from Dockerhub folks. |
This PR adds the static assets for AK 3.8.0 Docker Official Images.
Post this PR:
Committer Checklist (excluded from commit message)