-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR Capture heap dump after OOM on CI #19031
Open
mumrah
wants to merge
40
commits into
apache:trunk
Choose a base branch
from
mumrah:tmp-oom-in-flaky-test
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−2
Open
Changes from 10 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4baadb0
ignore the GC pause thing for now
mumrah d1e4af0
set the jvm arg in the right place
mumrah 641c0df
increase worker heap size
mumrah 76147b9
reduce heap to try to get a GC pause
mumrah 95240c1
speed up testing a bit for now
mumrah a22eb2a
disable caching
mumrah f4121f1
disable cache
mumrah d6e1e56
increase JUnit heap
mumrah fe16ad0
empty
mumrah 75dfd65
only run flaky 17
mumrah ce1d399
really disable the build cache
mumrah 59f5244
try getting a heap dump
mumrah 3c3bbdb
empty
mumrah 7a056c9
empty
mumrah 3d7b910
empty
mumrah ac2357b
force an oom
mumrah 5b5669b
checkstyle
mumrah b1d6a6e
checkstyle
mumrah 9eddadd
always archive heap dump
mumrah 3812530
dont retain heap dumps very long
mumrah dec43a7
find
mumrah 8f977fc
wip
mumrah fc49738
remove forced OOM
mumrah 98131ff
Merge remote-tracking branch 'origin/trunk' into tmp-oom-in-flaky-test
mumrah c86117b
wip
mumrah d44ea8c
empty
mumrah 32b6815
back to 2g heap
mumrah 46a8dad
add a bunch of runs
mumrah 5d0dceb
fix conflict
mumrah dfe417d
keep trying
mumrah ef377e5
still trying
mumrah dfa1359
lower count
mumrah b8d1c46
remove ls
mumrah 3d1bf90
empty
mumrah 8f6c75c
empty
mumrah 6829676
empty
mumrah 9dcbe73
revert some things
mumrah 603d6a0
empty
mumrah b8f66a4
Merge remote-tracking branch 'origin/trunk' into tmp-oom-in-flaky-test
mumrah ef070f3
increase retention
mumrah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijuma WDYT about disabling this feature? From what I can tell, this will prevent a long GC pause from triggering an OOM. Instead, the build would likely just timeout (which it's doing anyways with the OOM happing in the Gradle worker).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you said, the build is unlikely to succeed in either case. The GC overhead thing at least gives a hint that there is a memory leak or the heap is too small. Isn't that better than a timeout with no information?